Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#StandardizeGeneratedClassNames Change names of classes generated by vajram code generator #278

Open
RamAnvesh opened this issue Nov 21, 2024 · 0 comments
Labels
good first issue Good for newcomers size: xs super small change

Comments

@RamAnvesh
Copy link
Collaborator

Make sure that suffixes and prefixes don't class with existing and future concepts

Change VajramNameImpl to VajramNameWrapper: When we introduce Vajram inheritance via Vajram Protocols, presumably vajrams which implement the protocol will be named ProtocolNameImpl. To avoid this clashes, and to move away from the inhertance implications of Impl suffix, change it to Wrapper

Merge and Change VajramNameFacets and VajramNameFacetUtil to VajramName_Fcts: We want this name to be as short as possible while also being descriptive: VajramName_Facets is too long, VajramName_F is too cryptic.

Change VajramNameFacetUtil.VajramNameCommonFacets to VajramName_CommonFcts top level class.
Change VajramNameFacetUtil.VajramNameBatchFacets to VajramName_BatchFcts top level class.

@RamAnvesh RamAnvesh added good first issue Good for newcomers size: xs super small change labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers size: xs super small change
Projects
None yet
Development

No branches or pull requests

1 participant