Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#DeprecateInputDefSources Deprecate "sources()" method in InputDef and rely on the AnnotationTag to determine if Injection is needed #288

Open
RamAnvesh opened this issue Nov 25, 2024 · 1 comment
Open

#DeprecateInputDefSources Deprecate "sources()" method in InputDef and rely on the AnnotationTag to determine if Injection is needed #288

RamAnvesh opened this issue Nov 25, 2024 · 1 comment
Labels
good first issue Good for newcomers size: s Small change
Milestone
v9

Comments

@RamAnvesh
Copy link
Collaborator

No description provided.

@RamAnvesh RamAnvesh added good first issue Good for newcomers size: s Small change v8 labels Nov 25, 2024
@RamAnvesh
Copy link
Collaborator Author

If this change is made, the auto-generated GraphQL Aggregator Vajrams will no longer work because they don't have facet fields in the facets class. This change can be made only after the code generator is changed to generate VajramDef class with _Facets class instead of generating the Impl class.

@RamAnvesh RamAnvesh added v9 and removed v8 labels Nov 29, 2024
@RamAnvesh RamAnvesh added this to the v9 milestone Dec 1, 2024
@RamAnvesh RamAnvesh removed the v9 label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers size: s Small change
Projects
None yet
Milestone
v9
Development

No branches or pull requests
1 participant
@RamAnvesh