"Federated Learning" shield study is not removed when the "Disable" button from "about:addons" page is clicked

[SoftVision-CarmenFat]

[Affected versions]:

• Firefox 62.0b6

[Affected Platforms]:

• All Windows
• All Linux
• All Mac

[Prerequisites]:

• Have a new Firefox profile with the latest version of the "Federated Learning" add-on installed.
• Have the 'extensions.legacy.enabled' pref set to 'true'.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Navigate to "about:addons>Extensions" and click the "Federated Learning" add-on.
3. Click the "Disable" button and observe the behavior.

[Expected result]:

• The "Federated Learning" experiment is uninstalled and no longer displayed on the page.

[Actual result]:

• The "Federated Learning" is disabled.

[Additional Notes]:

• After the study is re-enabled, the "install" and "enter" pings are sent again.
• Attached a screen recording of the issue:

[florian]

After talking to the shield team, I'm marking this as an upstream-issue.
This should ideally be fixed in the shield-studies-addon-utils library.
See mozilla/shield-studies-addon-utils#231 for the respective issue in that repository.

[gregglind]

OH! I Read this wrong. Okay, will look into it.

[florian]

#10 and 5710bc6 should've fixed this but didn't.
See mozilla/shield-studies-addon-utils#247 for a new bug in the shield library repo.

[MattGMoz]

This one also seems non-blocking to me. It's unfortunately something we need to fix upstream. If a user did re-enter the study we'd need to rely on the analyst to remove them from the data set.

[gregglind]

Since Florian is an analyst, he can know the risks here.

…

On Mon, Jul 16, 2018 at 4:04 PM, MattGMoz ***@***.***> wrote: This one also seems non-blocking to me. It's unfortunately something we need to fix upstream. If a user did re-enter the study we'd need to rely on the analyst to remove them from the data set. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKAj3ZnRifENMRxYchB9hMb0jCp-Q9kks5uHP_zgaJpZM4VHzbS> .