Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more keyboard shortcuts #152

Open
mrkam2 opened this issue Feb 17, 2024 · 2 comments
Open

Add more keyboard shortcuts #152

mrkam2 opened this issue Feb 17, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@mrkam2
Copy link

mrkam2 commented Feb 17, 2024

Here is a list of actions and recommended keyboard shortcuts for them:

  • Focus on Quick Jump - Cmd-K
  • Focus on Search - Cmd-F
    • Search forward - Cmd-G
    • Search backwards - Shift-Cmd-G
  • Focus on Search by Identity - Cmd-I
    • Next search by identity - Cmd-]
    • Previous search by identity - Cmd-[
  • Start/Stop recording - F5 or Cmd-R
  • Copy the current value in Inspector (consider File and its str-ed form) - Cmd-C
  • Tap in inspector - Cmd-T
  • Def in inspector - Cmd-D
  • Step Forward - F11 or Cmd-;
  • Step Backwards - Option-F11 or Shift-Cmd-; (I wish Shift-F11 was available for backwards step, similar for backwards search, but it is taken by Step Out, so I picked Option instead).
  • Step to the next interesting expression in the same frame - F10 or Cmd-'
  • same backwards - Option-F10 or Shift-Cmd-'
  • Step Out - Shift-F11 or Cmd-Up

Add them to tooltips/menu items for easy discovery.

@jpmonettas jpmonettas added the enhancement New feature or request label Feb 19, 2024
@jpmonettas
Copy link
Member

jpmonettas commented Feb 19, 2024

I see all this bindings are mac only, since they are using the Cmd button modifier, which is only available there.
So far we have been using Ctrl for all our bindings, so until we get a way of customizing key bindings I guess we would have to keep using Ctrl?
I have never used macOS so I'm not sure how apps use Ctrl and Cmd and how important is to get that right there.

Also a bunch of the purposed bindings are already defined under a different key or taken for something else, take a look at here https://flow-storm.github.io/flow-storm-debugger/user_guide.html#_key_bindings

@mrkam2
Copy link
Author

mrkam2 commented Feb 28, 2024

Sorry for the long delay - I was on vacation.

Yes, I'm on MacOS, so I'm biased towards MacOS shortcuts but these were simply the suggestions - feel free to choose appropriate alternatives.

In general, between MacOS and other systems, many shortcuts that use Ctrl on other systems, use Cmd on MacOS. For example, Cmd-C to Copy. Cmd-V to Paste. Other than being a different key (located where Alt is on some non-Mac keyboards), and being a standard key for most shortcuts (just as Ctrl is standard in Windows) there are no other significant differences. MacOS also has Ctrl, Option (same as Alt) and Shift keys, all can be used in the shortcuts.

It is not critical to implement a different set of shortcuts for MacOS although may be a nice usability improvement in future. Having shortcuts for commands seems more important than having a very specific and/or platform-specific ones.

And sorry for suggesting shortcuts that are already taken - I didn't check all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants