Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement EIC counter for normal execution mode #771

Closed
mikevoronov opened this issue Aug 5, 2019 · 2 comments · Fixed by #847
Closed

Implement EIC counter for normal execution mode #771

mikevoronov opened this issue Aug 5, 2019 · 2 comments · Fixed by #847
Assignees
@mikevoronov
Labels
enhancement scala tech: scala ~virtual machine component: virtual machine

Comments

@mikevoronov
Copy link
Member

According to our protocol, executed instruction counter (EIC) is used in a dispute and in VM state hash computing. So it needs to track it along with gas (#165) in normal VM execution mode.
@mikevoronov mikevoronov self-assigned this Aug 5, 2019
@mikevoronov mikevoronov added enhancement scala tech: scala ~virtual machine component: virtual machine labels Aug 5, 2019
@mikevoronov mikevoronov mentioned this issue Aug 8, 2019
Merged
@mikevoronov
Copy link
Member Author

Depends on cretz/asmble#30

@mikevoronov
Copy link
Member Author

With the choice of using Wasmer instead of Asmble, it isn't depend anymore and will be added in this PR.

@mikevoronov mikevoronov mentioned this issue Sep 30, 2019
Merged
@folex folex closed this as completed in #847 Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikevoronov mikevoronov

Labels
enhancement scala tech: scala ~virtual machine component: virtual machine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce the new VM called Frank based on Wasmer fluencelabs/nox
1 participant
@mikevoronov