From 6874330bcad5282e730500d5acfae753bfccf411 Mon Sep 17 00:00:00 2001 From: ryanohnemus Date: Sat, 3 Feb 2024 07:58:41 -0600 Subject: [PATCH] fixing lints Signed-off-by: ryanohnemus --- helpers/test-helpers.bash | 2 ++ run-tests.sh | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/helpers/test-helpers.bash b/helpers/test-helpers.bash index 41cccd7..afaf5eb 100755 --- a/helpers/test-helpers.bash +++ b/helpers/test-helpers.bash @@ -108,7 +108,9 @@ function create_helm_extra_values_file() { # by the test. This will fall back to $TEST_ROOT/defaults/values.yaml.tpl # if not passed. if [ -e "${HELM_VALUES_EXTRA_FILE}" ]; then + # shellcheck disable=SC2155 envsubst < "${HELM_VALUES_EXTRA_FILE}" > "$(dirname ${HELM_VALUES_EXTRA_FILE})/${TEST_NAMESPACE}.values.yaml" + # shellcheck disable=SC2086 export HELM_VALUES_EXTRA_FILE="$(dirname ${HELM_VALUES_EXTRA_FILE})/${TEST_NAMESPACE}.values.yaml" fi } \ No newline at end of file diff --git a/run-tests.sh b/run-tests.sh index 3d38b9c..e0ec08d 100755 --- a/run-tests.sh +++ b/run-tests.sh @@ -82,7 +82,7 @@ function run_tests() { # If TEST_NAMESPACE is not set (the default), we run jobs in parallel # otherwise, if it is set we can only run 1 job at a time and need to remove # all BATS_JOBS_PARAMS - if [[ ! -z "${TEST_NAMESPACE:-}" ]]; then + if [[ -n "${TEST_NAMESPACE:-}" ]]; then BATS_JOBS_PARAMS="" fi