Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The prebuilt whl package of snowboy seems to have wrong name #257

Closed
hongquan opened this issue Jul 13, 2018 · 7 comments
Closed

The prebuilt whl package of snowboy seems to have wrong name #257

hongquan opened this issue Jul 13, 2018 · 7 comments
Assignees
Labels

Comments

@hongquan
Copy link
Member

Describe the bug
I built snowboy on my RPI 3 to wheel package and uploaded to https://repo.fury.io/fossasia/. The file is named snowboy-1.3.0-py3-none-any.whl, but I suspect that this name is wrong. This package contains some *.so binary, compiled from C/C++ code. That *.so file will be different between ARM and x86, so the name suffix of package cannot be none-any. It should be linux_armv7l.

With the suffix none-any, I worry that pip on PC will mistakenly download this file and install, while the file was built for ARM7.

What to do

Try to fix setup.py build script.

@hongquan hongquan added the bug label Jul 13, 2018
@hongquan hongquan self-assigned this Jul 13, 2018
@hongquan
Copy link
Member Author

Normally, the pure-Python packages have none-any suffix.

@woshikie, you don't have snowboy on your laptop? What is its name?

@sansyrox
Copy link
Member

@hongquan , we do not have any setup.py script

@woshikie
Copy link
Member

@hongquan I have made some changes and it's compiling into correct names on my ubuntu
Kitt-AI/snowboy#475

@stealthanthrax we're trying to build snowboy into a wheel package for we can use pip3/pip to install from our own repository

@woshikie
Copy link
Member

woshikie commented Jul 13, 2018

@hongquan
here's a compiled wheel for armv6, compiled using Pi Zero W
snowboy-1.3.0-cp35-cp35m-linux_armv6l.whl.zip
and here's a compiled wheel for 64bit linux
snowboy-1.3.0-cp36-cp36m-linux_x86_64.whl.zip

@hongquan
Copy link
Member Author

@woshikie You have full permission on Gemfury repo. Please upload the file.

By the way, I'm looking for the better way to fix the setup.py script. Learning from other projects who also have Python modules built from Swig, they all use distutils.core.Extension or setuptools.extensions.Extension to build C/C++ code and hence, generating correct name.

Example:

@hongquan
Copy link
Member Author

we do not have any setup.py script

I meant snowboy's setup.py script.

@hongquan
Copy link
Member Author

Fixed by Kitt-AI/snowboy#493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants