We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
Noticed that the destructive button background color does not match the shadcn color on hover.
shadcn:
franken-ui:
I assume this is unintentional, as all other Zinc theme colors and CSS variables seem to match the shadcn colors.
This happens in both version 1 and 2.
In version 1:
.uk-button-danger:hover { opacity: .9; }
In version 2:
.uk-btn:hover { opacity: .8; }
Shadcn does this, instead of just opacity:
opacity
.hover\:bg-destructive\/90:hover { background-color: hsl(var(--destructive) / .9); }
But for the secondary button background color, shadcn uses 80% opacity:
.hover\:bg-secondary\/80:hover { background-color: hsl(var(--secondary) / .8); }
Which means .uk-btn cannot have the same hover opacity for all buttons, since they differ.
.uk-btn
I know this is a very minor nitpick, but I thought maybe this issue was missed.
Thanks for the great work!
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi,
Noticed that the destructive button background color does not match the shadcn color on hover.
shadcn:
franken-ui:
I assume this is unintentional, as all other Zinc theme colors and CSS variables seem to match the shadcn colors.
This happens in both version 1 and 2.
In version 1:
In version 2:
Shadcn does this, instead of just
opacity
:But for the secondary button background color, shadcn uses 80% opacity:
Which means
.uk-btn
cannot have the same hover opacity for all buttons, since they differ.I know this is a very minor nitpick, but I thought maybe this issue was missed.
Thanks for the great work!
The text was updated successfully, but these errors were encountered: