Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect background color opacity #47

Open
Teraskull opened this issue Dec 27, 2024 · 0 comments
Open

Incorrect background color opacity #47

Teraskull opened this issue Dec 27, 2024 · 0 comments

Comments

@Teraskull
Copy link

Hi,

Noticed that the destructive button background color does not match the shadcn color on hover.

shadcn:
image

franken-ui:
image

I assume this is unintentional, as all other Zinc theme colors and CSS variables seem to match the shadcn colors.

This happens in both version 1 and 2.

In version 1:

.uk-button-danger:hover {
    opacity: .9;
}

In version 2:

.uk-btn:hover {
    opacity: .8;
}

Shadcn does this, instead of just opacity:

.hover\:bg-destructive\/90:hover {
    background-color: hsl(var(--destructive) / .9);
}

But for the secondary button background color, shadcn uses 80% opacity:

.hover\:bg-secondary\/80:hover {
    background-color: hsl(var(--secondary) / .8);
}

Which means .uk-btn cannot have the same hover opacity for all buttons, since they differ.

I know this is a very minor nitpick, but I thought maybe this issue was missed.

Thanks for the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant