Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aarch64 apple darwin #29

Merged
merged 6 commits into from
May 19, 2021
Merged

aarch64 apple darwin #29

merged 6 commits into from
May 19, 2021

Conversation

franziskuskiefer
Copy link
Owner

Support for new platforms

  • aarch64-apple-darwin a.k.a. Apple Silicon
  • aarch64-apple-ios
  • x86_64-apple-ios

@codecov
Copy link

codecov bot commented May 17, 2021 •
edited
Loading

Codecov Report

Merging #29 (99ac4a5) into master (a903c8f) will not change coverage.
The diff coverage is n/a.

❗ Current head 99ac4a5 differs from pull request most recent head 2d2c884. Consider uploading reports for the commit 2d2c884 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   76.86%   76.86%           
=======================================
  Files          23       23           
  Lines        1059     1059           
=======================================
  Hits          814      814           
  Misses        245      245
Impacted Files Coverage Δ
evercrypt-sys/build.rs 0.00% <ø> (ø)

This was linked to issues May 18, 2021
Support aarch64-apple-darwin #26
Closed
x86_64-apple-ios target #27
Open
@franziskuskiefer franziskuskiefer self-assigned this May 18, 2021
@franziskuskiefer
Copy link
Owner Author

I still have to figure out what to do about x86_64-apple-ios. But @aspenluxxxy and @raphaelrobert can you check that this PR works for the other two targets for you?

@Absolucy
Copy link

Absolucy commented May 18, 2021 •
edited
Loading

Tests pass on both.
aarch64-apple-darwin:

image

aarch64-apple-ios:

image

@franziskuskiefer franziskuskiefer merged commit 1cd6611 into master May 19, 2021
@franziskuskiefer franziskuskiefer deleted the aarch64-apple-darwin branch May 19, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@franziskuskiefer franziskuskiefer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x86_64-apple-ios target Support aarch64-apple-darwin
2 participants
@franziskuskiefer @Absolucy