Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unkown template in test definitions breaks PR-CI #257

Open
netoarmando opened this issue Mar 11, 2019 · 1 comment
Open

Unkown template in test definitions breaks PR-CI #257

netoarmando opened this issue Mar 11, 2019 · 1 comment
Labels
difficulty:easy groomed Issues already discussed by the dev team prio:low type:bug

Comments

@netoarmando
Copy link
Member

netoarmando commented Mar 11, 2019

PR-CI breaks if some job passes a template that is not defined in the build job. This issue was observed in production, not yet reproduced in a development environment.

jobs:
  fedora-29/build:
    requires: []
    priority: 100
    job:
      class: Build
      args:
        git_repo: '{git_repo}'
        git_refspec: '{git_refspec}'
        template: &ci-master-f29 <--------------------
          name: freeipa/ci-master-f29
          version: 0.2.0
        timeout: 1800
        topology: *build

  fedora-29/temp_commit:
    requires: [fedora-29/build]
    priority: 50
    job:
      class: RunPytest
      args:
        build_url: '{fedora-29/build_url}'
        test_suite: test_integration/test_REPLACEME.py
        template: *ci-master-frawhide <--------------------
        timeout: 3600
        topology: *master_1repl_1client

This could cause PR-CI runners to increase the numbers of requests against Girthub's API and eventually hitting its rate limit, causing additional errors, like not posting data back to other pull requests.

@flo-renaud
Copy link
Contributor

Note: in freeipa workspace, you can run make yamllint to detect this type of issue before committing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:easy groomed Issues already discussed by the dev team prio:low type:bug
Projects
None yet
Development

No branches or pull requests

3 participants