Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async support #41

Open
Jovvik opened this issue May 22, 2024 · 2 comments
Open

Async support #41

Jovvik opened this issue May 22, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested

Comments

@Jovvik
Copy link

Jovvik commented May 22, 2024

The API functions are marked as async, but they use a synchronous HTTP client (minreq) internally. Do you plan on using an async HTTP client in the future?
@marcohoovy marcohoovy added enhancement New feature or request good first issue Good for newcomers question Further information is requested labels May 22, 2024
@marcohoovy
Copy link
Collaborator

When the macros were created they were async using reqwest, the change to minreq was made to lower dependencies. I think in the future the minreq client could be a feature flag and reqwest become the main client?

@garhow
Copy link
Owner

garhow commented May 22, 2024

When the macros were created they were async using reqwest, the change to minreq was made to lower dependencies. I think in the future the minreq client could be a feature flag and reqwest become the main client?

This would probably be the best option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marcohoovy @Jovvik @garhow