Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nic_router: reconsider internal Session_env (which is a Ram_allocator) #5405

Open
chelmuth opened this issue Dec 12, 2024 · 0 comments
Open

nic_router: reconsider internal Session_env (which is a Ram_allocator) #5405

chelmuth opened this issue Dec 12, 2024 · 0 comments
Labels
cleanup

Comments

@chelmuth
Copy link
Member

While declaring the Ram_allocator non-copyable it became apparent that Session_env has the requirement to be copyable in the current implementation. We should reconsider this internal structure.
chelmuth pushed a commit that referenced this issue Dec 12, 2024
@atopia @chelmuth
squash "base: make Ram_allocator noncopyable" (new commit message)
7fcfa4e 
Prevent erratic runtime behavior stemming from accidentally passing a
copy to a `Ram_allocator` by making the interface noncopyable.

In consequence, we had to provide an explicit copy constructor for
`Session_env` in server/nic_router, which will be reconsidered in
issue #5405.

Issue #5221
chelmuth pushed a commit that referenced this issue Jan 30, 2025
@atopia @chelmuth
base: make Ram_allocator noncopyable
f94f461 
Prevent erratic runtime behavior stemming from accidentally passing a
copy to a `Ram_allocator` by making the interface noncopyable.

In consequence, we had to provide an explicit copy constructor for
`Session_env` in server/nic_router, which will be reconsidered in
issue #5405.

Issue #5221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chelmuth