Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in DEPEND=">=virtual/rust-x.y.x" using rust-version from Cargo.toml #34

Open
vincentdephily opened this issue Mar 29, 2023 · 4 comments

Comments

@vincentdephily
Copy link

This is just a paper cut, but I imagine the fix is easy enough.

@gyakovlev
Copy link
Member

it's BDEPEND
also note that eclass specifies it's minimal rust version due to reliance on cargo features in particular release.
as even if upstream specifies minimum 1.57.0, if eclass uses 1.65.0 features - we should never go below eclass constraint.
https://github.com/gentoo/gentoo/blob/master/eclass/cargo.eclass#L37
this is current version
it will be bumped to 1.59.0

@gyakovlev
Copy link
Member

@gyakovlev
Copy link
Member

so if it somehow could read eclass's RUST_DEPEND and only set minimum version only if it's above RUST_DEPEND

@vincentdephily
Copy link
Author

Good catch re BDEPEND.

We could probably just concatenate the crate and eclass MSRV together, and let portage sort out the resulting minimum.

On that note, when does the eclass evaluate BDEPEND="${RUST_DEPEND}" ? Shouldn't it evaluate BDEPEND="${BDEPEND} ${RUST_DEPEND}" to avoid overwrites ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants