Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geoparquet read support to geozero-cli #242

Open
michaelkirk opened this issue Dec 13, 2024 · 3 comments · May be fixed by #247
Open

Add geoparquet read support to geozero-cli #242

michaelkirk opened this issue Dec 13, 2024 · 3 comments · May be fixed by #247

Comments

@michaelkirk
Copy link
Member

Since reading geoparquet is supported (#37), we should be able to add it as input to geozero-cli.

Any potential hangups you see @kylebarron?

@kylebarron
Copy link
Member

No obvious hurdles. I can give you pointers if you get stuck. You should be able to stream over the batches without loading the entire file into memory

@kylebarron
Copy link
Member

In particular you should be able to use a GeoParquetRecordBatchReader to iterate over record batches from the Parquet file. You can wrap each one as a Table, which implements GeozeroDatasource

@alekzvik alekzvik linked a pull request Dec 20, 2024 that will close this issue
@alekzvik
Copy link

I tried implementing it in the #247.

I did not go with the proposed Table approach, because each batch table would call dataset_begin and dataset_end which can influence writers down the road. I used GeozeroDatasource implementation for RecordBatchReader instead

@kylebarron let me know if you think it is a bad idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants