Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abilitity to exclude network tests and tests requiring 3rd party daemons #3711

Closed
anthonyryan1 opened this issue Oct 28, 2024 · 1 comment
Closed

Comments

@anthonyryan1
Copy link

Problem Statement

This is a tangent continuation of a comment in #3035

After speaking with the Gentoo developers, our only hope of cancelling the removal of sentry-python from Gentoo is to get all tests passing reliably with all versions of python 3.11+

Honestly, it looks pretty bleak currently. Even with Gentoo removing over 30 test groups, there's 133 test failures before the test runner itself crashes a quarter of the way through testing.

Some tests require API keys to 3rd party daemons running, some require network access. The test suite seems over-fitted and tightly coupled to your internal testing infrastructure, as opposed to being viable to run.

Solution Brainstorm

Could we get a built in solution to skip all network tests and 3rd party daemon tests (database servers, redis servers, etc. or that make API calls to network services)? So that it's not necessary for maintainers to constantly maintain a list of tests that don't make sense.

At least that would automatically exclude all tests that have no hope of running outside your specific test environment.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Oct 28, 2024
@szokeasaurusrex
Copy link
Member

@anthonyryan1 Thanks for opening the issue.

I discussed your feedback with the team. While we understand that having a built-in solution to skip network tests and 3rd party daemon tests would be helpful for folks maintaining unofficial sentry-python packages, we would rather focus our time on building new features or fixing bugs to create more value for users. If you or anyone else from the community would like to add support for this use case, we would be happy to accept PRs, but this is low-priority for our team.

Users can still install the official Sentry SDK package from PyPI using pip install sentry-sdk if Gentoo drops its support for its unofficial Sentry-Python package. Our recommendation is to always install the official PyPI distribution with pip, since using pip is the only installation method we support.

@anthonyryan1 anthonyryan1 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants