From 5b09f71882a614427b009ee2797bf1393556d7a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lu=C3=ADs=20Pereira?= Date: Wed, 25 Nov 2020 16:37:34 +0000 Subject: [PATCH] Use = default for trivial contructors/destructors --- panel/lxqtpanelpluginconfigdialog.cpp | 4 +--- panel/pluginmoveprocessor.cpp | 4 +--- panel/pluginsettings.cpp | 4 +--- plugin-colorpicker/colorpicker.cpp | 8 ++------ plugin-desktopswitch/desktopswitch.cpp | 4 +--- plugin-kbindicator/kbindicator-plugin.cpp | 3 +-- plugin-kbindicator/src/content.cpp | 3 +-- plugin-kbindicator/src/kbdkeeper.cpp | 9 +++------ plugin-kbindicator/src/kbdstate.cpp | 3 +-- plugin-kbindicator/src/settings.cpp | 3 +-- plugin-kbindicator/src/x11/kbdlayout.cpp | 3 +-- plugin-mainmenu/actionview.cpp | 3 +-- plugin-mount/actions/deviceaction.cpp | 4 +--- plugin-mount/actions/ejectaction.cpp | 4 +--- plugin-mount/button.cpp | 4 +--- plugin-mount/menudiskitem.cpp | 4 +--- plugin-networkmonitor/lxqtnetworkmonitor.cpp | 4 +--- plugin-quicklaunch/lxqtquicklaunch.cpp | 4 +--- plugin-quicklaunch/quicklaunchbutton.cpp | 6 +----- plugin-sensors/lxqtsensors.cpp | 4 +--- plugin-statusnotifier/statusnotifieriteminterface.cpp | 4 +--- plugin-sysstat/lxqtsysstat.cpp | 9 ++------- plugin-taskbar/lxqtgrouppopup.cpp | 4 +--- plugin-taskbar/lxqttaskbutton.cpp | 4 +--- plugin-tray/lxqttrayconfiguration.cpp | 2 +- plugin-tray/xfitman.cpp | 4 +--- plugin-volume/audiodevice.cpp | 4 +--- plugin-volume/volumebutton.cpp | 4 +--- 28 files changed, 32 insertions(+), 88 deletions(-) diff --git a/panel/lxqtpanelpluginconfigdialog.cpp b/panel/lxqtpanelpluginconfigdialog.cpp index f9c98bbe6..0978f13a6 100644 --- a/panel/lxqtpanelpluginconfigdialog.cpp +++ b/panel/lxqtpanelpluginconfigdialog.cpp @@ -46,9 +46,7 @@ LXQtPanelPluginConfigDialog::LXQtPanelPluginConfigDialog(PluginSettings &setting /************************************************ ************************************************/ -LXQtPanelPluginConfigDialog::~LXQtPanelPluginConfigDialog() -{ -} +LXQtPanelPluginConfigDialog::~LXQtPanelPluginConfigDialog() = default; /************************************************ diff --git a/panel/pluginmoveprocessor.cpp b/panel/pluginmoveprocessor.cpp index 30f0ddd09..b989f62ae 100644 --- a/panel/pluginmoveprocessor.cpp +++ b/panel/pluginmoveprocessor.cpp @@ -49,9 +49,7 @@ PluginMoveProcessor::PluginMoveProcessor(LXQtPanelLayout *layout, Plugin *plugin /************************************************ ************************************************/ -PluginMoveProcessor::~PluginMoveProcessor() -{ -} +PluginMoveProcessor::~PluginMoveProcessor() = default; /************************************************ diff --git a/panel/pluginsettings.cpp b/panel/pluginsettings.cpp index 30edf7136..d5a2be958 100644 --- a/panel/pluginsettings.cpp +++ b/panel/pluginsettings.cpp @@ -72,9 +72,7 @@ QString PluginSettings::group() const return d->mGroup; } -PluginSettings::~PluginSettings() -{ -} +PluginSettings::~PluginSettings() = default; QVariant PluginSettings::value(const QString &key, const QVariant &defaultValue) const { diff --git a/plugin-colorpicker/colorpicker.cpp b/plugin-colorpicker/colorpicker.cpp index d15d54a8a..3cc0585b5 100644 --- a/plugin-colorpicker/colorpicker.cpp +++ b/plugin-colorpicker/colorpicker.cpp @@ -39,9 +39,7 @@ ColorPicker::ColorPicker(const ILXQtPanelPluginStartupInfo &startupInfo) : } -ColorPicker::~ColorPicker() -{ -} +ColorPicker::~ColorPicker() = default; void ColorPicker::realign() @@ -75,9 +73,7 @@ ColorPickerWidget::ColorPickerWidget(QWidget *parent): } -ColorPickerWidget::~ColorPickerWidget() -{ -} +ColorPickerWidget::~ColorPickerWidget() = default; void ColorPickerWidget::mouseReleaseEvent(QMouseEvent *event) diff --git a/plugin-desktopswitch/desktopswitch.cpp b/plugin-desktopswitch/desktopswitch.cpp index 1fbd2c663..d3935c942 100644 --- a/plugin-desktopswitch/desktopswitch.cpp +++ b/plugin-desktopswitch/desktopswitch.cpp @@ -206,9 +206,7 @@ bool DesktopSwitch::isWindowHighlightable(WId window) return !NET::typeMatchesMask(info.windowType(NET::AllTypesMask), normalFlag); } -DesktopSwitch::~DesktopSwitch() -{ -} +DesktopSwitch::~DesktopSwitch() = default; void DesktopSwitch::setDesktop(int desktop) { diff --git a/plugin-kbindicator/kbindicator-plugin.cpp b/plugin-kbindicator/kbindicator-plugin.cpp index e5812c920..b2e69b0c8 100644 --- a/plugin-kbindicator/kbindicator-plugin.cpp +++ b/plugin-kbindicator/kbindicator-plugin.cpp @@ -36,8 +36,7 @@ class LXQtKbIndicatorPlugin: public QObject, public ILXQtPanelPluginLibrary Q_PLUGIN_METADATA(IID "lxqt.org/Panel/PluginInterface/3.0") Q_INTERFACES(ILXQtPanelPluginLibrary) public: - ~LXQtKbIndicatorPlugin() override - {} + ~LXQtKbIndicatorPlugin() override = default; ILXQtPanelPlugin *instance(const ILXQtPanelPluginStartupInfo &startupInfo) const override { diff --git a/plugin-kbindicator/src/content.cpp b/plugin-kbindicator/src/content.cpp index a2d1696b5..ed034108d 100644 --- a/plugin-kbindicator/src/content.cpp +++ b/plugin-kbindicator/src/content.cpp @@ -71,8 +71,7 @@ Content::Content(bool layoutEnabled): box->addWidget(m_layout, 0, Qt::AlignCenter); } -Content::~Content() -{} +Content::~Content() = default; bool Content::setup() { diff --git a/plugin-kbindicator/src/kbdkeeper.cpp b/plugin-kbindicator/src/kbdkeeper.cpp index 16cbae08f..5c333d781 100644 --- a/plugin-kbindicator/src/kbdkeeper.cpp +++ b/plugin-kbindicator/src/kbdkeeper.cpp @@ -39,8 +39,7 @@ KbdKeeper::KbdKeeper(const KbdLayout & layout, KeeperType type): m_layout.readKbdInfo(m_info); } -KbdKeeper::~KbdKeeper() -{} +KbdKeeper::~KbdKeeper() = default; bool KbdKeeper::setup() { @@ -89,8 +88,7 @@ WinKbdKeeper::WinKbdKeeper(const KbdLayout & layout): KbdKeeper(layout, KeeperType::Window) {} -WinKbdKeeper::~WinKbdKeeper() -{} +WinKbdKeeper::~WinKbdKeeper() = default; void WinKbdKeeper::layoutChanged(uint group) { @@ -137,8 +135,7 @@ AppKbdKeeper::AppKbdKeeper(const KbdLayout & layout): KbdKeeper(layout, KeeperType::Window) {} -AppKbdKeeper::~AppKbdKeeper() -{} +AppKbdKeeper::~AppKbdKeeper() = default; void AppKbdKeeper::layoutChanged(uint group) { diff --git a/plugin-kbindicator/src/kbdstate.cpp b/plugin-kbindicator/src/kbdstate.cpp index 4279a427c..769d6c92d 100644 --- a/plugin-kbindicator/src/kbdstate.cpp +++ b/plugin-kbindicator/src/kbdstate.cpp @@ -46,8 +46,7 @@ KbdState::KbdState(const ILXQtPanelPluginStartupInfo &startupInfo): settingsChanged(); } -KbdState::~KbdState() -{} +KbdState::~KbdState() = default; void KbdState::settingsChanged() { diff --git a/plugin-kbindicator/src/settings.cpp b/plugin-kbindicator/src/settings.cpp index 16bfd1ed9..09e18a7ec 100644 --- a/plugin-kbindicator/src/settings.cpp +++ b/plugin-kbindicator/src/settings.cpp @@ -27,8 +27,7 @@ #include #include "settings.h" -Settings::Settings() -{} +Settings::Settings() = default; Settings &Settings::instance() { diff --git a/plugin-kbindicator/src/x11/kbdlayout.cpp b/plugin-kbindicator/src/x11/kbdlayout.cpp index 33319d64a..90c2b0bcc 100644 --- a/plugin-kbindicator/src/x11/kbdlayout.cpp +++ b/plugin-kbindicator/src/x11/kbdlayout.cpp @@ -306,8 +306,7 @@ X11Kbd::X11Kbd(): m_priv(new pimpl::X11Kbd(this)) {} -X11Kbd::~X11Kbd() -{} +X11Kbd::~X11Kbd() = default; bool X11Kbd::init() { return m_priv->init(); } diff --git a/plugin-mainmenu/actionview.cpp b/plugin-mainmenu/actionview.cpp index b2521b931..2185e09b9 100644 --- a/plugin-mainmenu/actionview.cpp +++ b/plugin-mainmenu/actionview.cpp @@ -47,8 +47,7 @@ FilterProxyModel::FilterProxyModel(QObject* parent) : QSortFilterProxyModel(parent) { } -FilterProxyModel::~FilterProxyModel() { -} +FilterProxyModel::~FilterProxyModel() = default; bool FilterProxyModel::filterAcceptsRow(int source_row, const QModelIndex& source_parent) const { if (filterStr_.isEmpty()) diff --git a/plugin-mount/actions/deviceaction.cpp b/plugin-mount/actions/deviceaction.cpp index 405544d2a..206de4d08 100644 --- a/plugin-mount/actions/deviceaction.cpp +++ b/plugin-mount/actions/deviceaction.cpp @@ -48,9 +48,7 @@ DeviceAction::DeviceAction(LXQtMountPlugin *plugin, QObject *parent) { } -DeviceAction::~DeviceAction() -{ -} +DeviceAction::~DeviceAction() = default; DeviceAction *DeviceAction::create(ActionId id, LXQtMountPlugin *plugin, QObject *parent) { diff --git a/plugin-mount/actions/ejectaction.cpp b/plugin-mount/actions/ejectaction.cpp index 75e4d333b..fd9a39e2d 100644 --- a/plugin-mount/actions/ejectaction.cpp +++ b/plugin-mount/actions/ejectaction.cpp @@ -42,9 +42,7 @@ EjectAction::EjectAction(LXQtMountPlugin *plugin, QObject *parent) { } -EjectAction::~EjectAction() -{ -} +EjectAction::~EjectAction() = default; EjectAction *EjectAction::create(ActionId id, LXQtMountPlugin *plugin, QObject *parent) { diff --git a/plugin-mount/button.cpp b/plugin-mount/button.cpp index e9ae4826d..a5bd67d66 100644 --- a/plugin-mount/button.cpp +++ b/plugin-mount/button.cpp @@ -40,6 +40,4 @@ Button::Button(QWidget * parent) : setAutoRaise(true); } -Button::~Button() -{ -} +Button::~Button() = default; diff --git a/plugin-mount/menudiskitem.cpp b/plugin-mount/menudiskitem.cpp index 96bac5294..1554ef4b6 100644 --- a/plugin-mount/menudiskitem.cpp +++ b/plugin-mount/menudiskitem.cpp @@ -78,9 +78,7 @@ MenuDiskItem::MenuDiskItem(Solid::Device device, Popup *popup): updateMountStatus(); } -MenuDiskItem::~MenuDiskItem() -{ -} +MenuDiskItem::~MenuDiskItem() = default; void MenuDiskItem::setMountStatus(bool mounted) { diff --git a/plugin-networkmonitor/lxqtnetworkmonitor.cpp b/plugin-networkmonitor/lxqtnetworkmonitor.cpp index 4cd502599..8cdab66bb 100644 --- a/plugin-networkmonitor/lxqtnetworkmonitor.cpp +++ b/plugin-networkmonitor/lxqtnetworkmonitor.cpp @@ -66,9 +66,7 @@ LXQtNetworkMonitor::LXQtNetworkMonitor(ILXQtPanelPlugin *plugin, QWidget* parent settingsChanged(); } -LXQtNetworkMonitor::~LXQtNetworkMonitor() -{ -} +LXQtNetworkMonitor::~LXQtNetworkMonitor() = default; void LXQtNetworkMonitor::resizeEvent(QResizeEvent *) { diff --git a/plugin-quicklaunch/lxqtquicklaunch.cpp b/plugin-quicklaunch/lxqtquicklaunch.cpp index ce6bb1103..dc7dc6b1d 100644 --- a/plugin-quicklaunch/lxqtquicklaunch.cpp +++ b/plugin-quicklaunch/lxqtquicklaunch.cpp @@ -107,9 +107,7 @@ LXQtQuickLaunch::LXQtQuickLaunch(ILXQtPanelPlugin *plugin, QWidget* parent) : } -LXQtQuickLaunch::~LXQtQuickLaunch() -{ -} +LXQtQuickLaunch::~LXQtQuickLaunch() = default; int LXQtQuickLaunch::indexOfButton(QuickLaunchButton* button) const diff --git a/plugin-quicklaunch/quicklaunchbutton.cpp b/plugin-quicklaunch/quicklaunchbutton.cpp index ba031db57..339336162 100644 --- a/plugin-quicklaunch/quicklaunchbutton.cpp +++ b/plugin-quicklaunch/quicklaunchbutton.cpp @@ -78,11 +78,7 @@ QuickLaunchButton::QuickLaunchButton(QuickLaunchAction * act, ILXQtPanelPlugin * this, SLOT(this_customContextMenuRequested(const QPoint&))); } - -QuickLaunchButton::~QuickLaunchButton() -{ - //m_act->deleteLater(); -} +QuickLaunchButton::~QuickLaunchButton() = default; QHash QuickLaunchButton::settingsMap() diff --git a/plugin-sensors/lxqtsensors.cpp b/plugin-sensors/lxqtsensors.cpp index 67bd6ecde..a0c713d8c 100644 --- a/plugin-sensors/lxqtsensors.cpp +++ b/plugin-sensors/lxqtsensors.cpp @@ -118,9 +118,7 @@ LXQtSensors::LXQtSensors(ILXQtPanelPlugin *plugin, QWidget* parent): } -LXQtSensors::~LXQtSensors() -{ -} +LXQtSensors::~LXQtSensors() = default; void LXQtSensors::updateSensorReadings() diff --git a/plugin-statusnotifier/statusnotifieriteminterface.cpp b/plugin-statusnotifier/statusnotifieriteminterface.cpp index d911dc138..6fbe54fe1 100644 --- a/plugin-statusnotifier/statusnotifieriteminterface.cpp +++ b/plugin-statusnotifier/statusnotifieriteminterface.cpp @@ -48,7 +48,5 @@ StatusNotifierItemInterface::StatusNotifierItemInterface(const QString &service, { } -StatusNotifierItemInterface::~StatusNotifierItemInterface() -{ -} +StatusNotifierItemInterface::~StatusNotifierItemInterface() = default; diff --git a/plugin-sysstat/lxqtsysstat.cpp b/plugin-sysstat/lxqtsysstat.cpp index ecbb1b860..933dc657b 100644 --- a/plugin-sysstat/lxqtsysstat.cpp +++ b/plugin-sysstat/lxqtsysstat.cpp @@ -99,10 +99,7 @@ LXQtSysStatTitle::LXQtSysStatTitle(QWidget *parent): } -LXQtSysStatTitle::~LXQtSysStatTitle() -{ - -} +LXQtSysStatTitle::~LXQtSysStatTitle() = default; bool LXQtSysStatTitle::event(QEvent *e) { @@ -125,9 +122,7 @@ LXQtSysStatContent::LXQtSysStatContent(ILXQtPanelPlugin *plugin, QWidget *parent setObjectName(QStringLiteral("SysStat_Graph")); } -LXQtSysStatContent::~LXQtSysStatContent() -{ -} +LXQtSysStatContent::~LXQtSysStatContent() = default; // I don't like macros very much, but writing dozen similar functions is much much worse. diff --git a/plugin-taskbar/lxqtgrouppopup.cpp b/plugin-taskbar/lxqtgrouppopup.cpp index 3e2f32830..822416865 100644 --- a/plugin-taskbar/lxqtgrouppopup.cpp +++ b/plugin-taskbar/lxqtgrouppopup.cpp @@ -62,9 +62,7 @@ LXQtGroupPopup::LXQtGroupPopup(LXQtTaskGroup *group): mCloseTimer.setInterval(400); } -LXQtGroupPopup::~LXQtGroupPopup() -{ -} +LXQtGroupPopup::~LXQtGroupPopup() = default; void LXQtGroupPopup::dropEvent(QDropEvent *event) { diff --git a/plugin-taskbar/lxqttaskbutton.cpp b/plugin-taskbar/lxqttaskbutton.cpp index 298b58082..6711b8968 100644 --- a/plugin-taskbar/lxqttaskbutton.cpp +++ b/plugin-taskbar/lxqttaskbutton.cpp @@ -122,9 +122,7 @@ LXQtTaskButton::LXQtTaskButton(const WId window, LXQtTaskBar * taskbar, QWidget /************************************************ ************************************************/ -LXQtTaskButton::~LXQtTaskButton() -{ -} +LXQtTaskButton::~LXQtTaskButton() = default; /************************************************ diff --git a/plugin-tray/lxqttrayconfiguration.cpp b/plugin-tray/lxqttrayconfiguration.cpp index 2e7a93bf2..4a3e9b212 100644 --- a/plugin-tray/lxqttrayconfiguration.cpp +++ b/plugin-tray/lxqttrayconfiguration.cpp @@ -47,7 +47,7 @@ LXQtTrayConfiguration::LXQtTrayConfiguration(PluginSettings *settings, QWidget * connect(ui->buttons, &QDialogButtonBox::clicked, this, &LXQtTrayConfiguration::dialogButtonsAction); } -LXQtTrayConfiguration::~LXQtTrayConfiguration() {} +LXQtTrayConfiguration::~LXQtTrayConfiguration() = default; void LXQtTrayConfiguration::loadSettings() { diff --git a/plugin-tray/xfitman.cpp b/plugin-tray/xfitman.cpp index 04607f7da..b6e16efd3 100644 --- a/plugin-tray/xfitman.cpp +++ b/plugin-tray/xfitman.cpp @@ -187,9 +187,7 @@ bool XfitMan::getClientIcon(Window _wid, QIcon *icon) const /** * @brief destructor */ -XfitMan::~XfitMan() -{ -} +XfitMan::~XfitMan() = default; /** * @brief returns a windowname and sets _nameSource to the finally used Atom diff --git a/plugin-volume/audiodevice.cpp b/plugin-volume/audiodevice.cpp index 1e29afb5b..2eae98881 100644 --- a/plugin-volume/audiodevice.cpp +++ b/plugin-volume/audiodevice.cpp @@ -38,9 +38,7 @@ AudioDevice::AudioDevice(AudioDeviceType t, AudioEngine *engine, QObject *parent { } -AudioDevice::~AudioDevice() -{ -} +AudioDevice::~AudioDevice() = default; void AudioDevice::setName(const QString &name) { diff --git a/plugin-volume/volumebutton.cpp b/plugin-volume/volumebutton.cpp index 45a1b216c..428cf5433 100644 --- a/plugin-volume/volumebutton.cpp +++ b/plugin-volume/volumebutton.cpp @@ -66,9 +66,7 @@ VolumeButton::VolumeButton(ILXQtPanelPlugin *plugin, QWidget* parent): connect(m_volumePopup, SIGNAL(stockIconChanged(QString)), this, SLOT(handleStockIconChanged(QString))); } -VolumeButton::~VolumeButton() -{ -} +VolumeButton::~VolumeButton() = default; void VolumeButton::setShowOnClicked(bool state) {