-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circular dependency #146
Comments
Hi @WaPoNe thanks for the heads up, we are looking into it. I think it happens when you download Magento and the extension, and then try to set up Magento when the extension is already present. Checking this possibility. Also: can you please open a ticket for better tracking? Thanks! |
@Ynhockey the case I showed you is the simplest obtained after a deep debug. And then, where should I open the ticket you're mentioning? |
Hi @WaPoNe the patch on the bug/circular-dependency-issue branch should remove the circular dependency. We are also working on a bigger refactor, but this should do the trick in your case. Please let me know if this works on your test system, and at the same time we are also doing our own tests before release. Thanks! |
Hi @Ynhockey, |
It's on the bug/circular-dependency-issue branch. Compare link: |
It's in 6.1.1, please let me know if there are additional issues. |
System: Magento Version: Magento Open Source ver. 2.4.5/2.4.5-p3 Vanilla
PHP Version: 8.1
Gigya Version: gigya/magento2-im: 6.0.0/6.1.0
Issue description:
Installed the extension in a Vanilla instance, it works fine.
If I create my module with a frontend observer (<mage_dir>/app/code/Vendor/Module/etc/frontend/events.xml):
to get data from customer session (<mage_dir>/app/code/Vendor/Module/Observer/SessionInit.php)
when I try to login, I get this message error:
1 exception(s):
Exception #0 (LogicException): Circular dependency: Gigya\GigyaIM\Observer\FrontendMagentoCustomerEnricher depends on Gigya\GigyaIM\Helper\GigyaMageHelper and vice versa.
Could you solve the problem?
It is blocking a wide project.
The text was updated successfully, but these errors were encountered: