From f361a4d944dc186a7768f331ad8b0b424239d80a Mon Sep 17 00:00:00 2001 From: appleboy Date: Sun, 29 Dec 2024 10:09:12 +0800 Subject: [PATCH] refactor: switch to structured logging with `log/slog` and update error handling - Add `bearer.yml` file with rules to skip specific checks - Replace `log` package with `log/slog` in `sessions.go` - Simplify error format string in `sessions.go` - Update error logging in `sessions.go` to use `slog.Error` with structured logging and return `nil` on error Signed-off-by: appleboy --- bearer.yml | 2 ++ sessions.go | 9 ++++++--- 2 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 bearer.yml diff --git a/bearer.yml b/bearer.yml new file mode 100644 index 0000000..92de57d --- /dev/null +++ b/bearer.yml @@ -0,0 +1,2 @@ +rule: + skip-rule: [go_gorilla_cookie_missing_http_only, go_gorilla_insecure_cookie] diff --git a/sessions.go b/sessions.go index 0ef8ec4..da88575 100644 --- a/sessions.go +++ b/sessions.go @@ -1,7 +1,7 @@ package sessions import ( - "log" + "log/slog" "net/http" "github.com/gin-gonic/gin" @@ -11,7 +11,7 @@ import ( const ( DefaultKey = "github.com/gin-contrib/sessions" - errorFormat = "[sessions] ERROR! %s\n" + errorFormat = "[sessions] ERROR!" ) type Store interface { @@ -131,7 +131,10 @@ func (s *session) Session() *sessions.Session { var err error s.session, err = s.store.Get(s.request, s.name) if err != nil { - log.Printf(errorFormat, err) + slog.Error(errorFormat, + "err", err, + ) + return nil } } return s.session