Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Option for slanted edges #52

Open
2 tasks
soni801 opened this issue Dec 19, 2024 · 2 comments
Open
2 tasks

[Feature]: Option for slanted edges #52

soni801 opened this issue Dec 19, 2024 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@soni801
Copy link

soni801 commented Dec 19, 2024

Description

Currently, the base of the output model has vertically straight edges. Although this looks fine by itself, it doesn't match models previously created/printed from the old GH skyline experience (https://skyline.github.com/). In said solution, the edges were slightly slanted as to make the bottom of the base slightly larger than the top.

Having a command line flag to generate the model with these slanted edges would more easily let users 3D-print the skyline matching their previous ones from the old website, thus eliminating the need to re-print previous years for consistency across models.

Requirements

  • Any way for the user to specify that a slanted base is wanted.

Definition of Done

  • A command line flag or option (see additional notes) letting the user choose to have a slanted base
  • Updated command line flag/option documentation

Additional Notes

There's two approaches I can see to this:

  • letting the user pass a flag (for example -s for slanted base). When this flag is passed, the command will generate a model with a slanted base.
  • Introducing an option for "base type" (or something similar), having multiple choices for how the user wishes the base to be generated. This is probably overkill for this minor change, but may be extended in the future if more model types are to be added.
    • Examples: gh skyline --base-type flat and gh skyline --base-type slanted will produce models with the current base design or a slanted base design, respectively. Defaults to flat if omitted.
@soni801 soni801 added enhancement New feature or request triage Issues to be triaged labels Dec 19, 2024
@github-project-automation github-project-automation bot moved this to Needs Review in gh-skyline Dec 19, 2024
@doctorixx
Copy link

100 %

@chrisreddington
Copy link
Collaborator

Thanks @soni801! Interestingly, this was something we discussed internally before releasing this version of Skyline and opted for the flat edges rather than slanted.

I'll unassigned myself from this, in case someone from the community wishes to take it on 😄 I'd also be interested in gauging how many folks are interested in this (and potentially additional base types as you hint!)

@chrisreddington chrisreddington moved this from Needs Review to Ready to Start in gh-skyline Dec 28, 2024
@chrisreddington chrisreddington added help wanted Extra attention is needed and removed triage Issues to be triaged labels Dec 28, 2024
@chrisreddington chrisreddington removed their assignment Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Ready to Start
Development

No branches or pull requests

3 participants