Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull Request Application ref can be wrong #1

Open
dudo opened this issue Jan 9, 2025 · 0 comments · May be fixed by #5
Open

Pull Request Application ref can be wrong #1

dudo opened this issue Jan 9, 2025 · 0 comments · May be fixed by #5
Labels
bug Something isn't working

Comments

@dudo
Copy link
Contributor

dudo commented Jan 9, 2025 •
edited
Loading

https://github.com/gitops-ci-cd/argo-config/blob/main/app-of-apps/apps/auto-discovery/preview.yaml#L60

We have a "bug" within the matrix generator where scmProvider and pullRequest have conflicting .branch values. There's currently no way to differentiate the two, but the issue has been noted in argo-cd, and a pull request is open to address it.

We're able to bypass the issue by using .branch_slug, which does work, but only for branch names that conform to the DNS label standard as defined in RFC 1123.
@dudo dudo changed the title GitHub deployment statuses not being updated Pull Request Application ref can be wrong Jan 16, 2025
@dudo dudo mentioned this issue Jan 16, 2025
Closed
@dudo dudo added the bug Something isn't working label Jan 16, 2025
@dudo dudo linked a pull request Jan 16, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address PR ref gitops-ci-cd/argo-config
Address PR generator ref gitops-ci-cd/argo-config
1 participant
@dudo