Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctness regression on x86 architecture #228

Open
deenp03 opened this issue Nov 6, 2024 · 1 comment
Open

Correctness regression on x86 architecture #228

deenp03 opened this issue Nov 6, 2024 · 1 comment

Comments

@deenp03
Copy link

deenp03 commented Nov 6, 2024

Overview of the Issue

After commit 74afbcecf5e15244c1eca605a2a2c5dc95c41f0a, hyperscan-java switched from Hyperscan 5.4.0 to Vectorscan 5.4.11 which means that hyperscan-java now supports ARM. However, a critical x86 bug was recently discovered in Vectorscan 5.4.11: VectorCamp/vectorscan#317.

This bug prevents us from using hyperscan-java version 5.4.11-3.0.0 because it's giving us incorrect results on x86.

Impact

We had to revert to 5.4.0-2.0.0 in order to get correct results on our x86 machines in production, but this comes with several issues:

Proposed Solution

  1. While we wait for a Vectorscan fix/release: cut a new alternative release of hyperscan-java using the latest hyperscan release which works on x86. This release would include hyperscan-java's other latest changes including: Fix a race condition in Scanner (closes #158) #159 Fix Database and Scratch instances not reclaimable by GC (closes #161) #162. This alternative release could use a label (e.g. "-x86").
  2. After a Vectorscan fix/release: cut a new release of hyperscan-java using the latest Vectorscan release.
@gliwka
Copy link
Owner

gliwka commented Nov 9, 2024

Thanks for finding this bug.

I will cut a release candidate build based on hyperscan-java main and the latest vectorscan release with the patch applied.

Once vectorscan has a new release upstream, I will publish a proper release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants