Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: robustness enhancement of regression tests #4433

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

chen1195585098
Copy link
Contributor

Results of some regression tests may vary on diffirent env, due to the unready status of shd process or unexpected output language of key commands in test case.

So, it should be made sure that shd process has got ready before a gluster v heal cmd is triggered in testcase. And if the output of command is the judge standard of sub-testcase, we also shuold assure it is shown in specified language as expected.

Fixes: #4432

Results of some regression tests may vary on diffirent env,
due to the unready status of shd process or unexpected
output language of key commands in test case.

So, it should be made sure that shd process has got ready before
a `gluster v heal` cmd is triggered in testcase. And if the output
of command is the judge standard of sub-testcase, we also shuold
assure it is shown in specified language as expected.

Fixes: gluster#4432
Signed-off-by: chenjinhao <[email protected]>
@gluster-ant
Copy link
Collaborator

Can one of the admins verify this patch?

2 similar comments
@gluster-ant
Copy link
Collaborator

Can one of the admins verify this patch?

@gluster-ant
Copy link
Collaborator

Can one of the admins verify this patch?

@amarts
Copy link
Member

amarts commented Nov 28, 2024

/run regression

Copy link
Member

@amarts amarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gluster-ant
Copy link
Collaborator

1 test(s) failed
./tests/00-geo-rep/00-georep-verify-non-root-setup.t

0 test(s) generated core

1 test(s) needed retry
./tests/00-geo-rep/00-georep-verify-non-root-setup.t
https://build.gluster.org/job/gh_centos7-regression/3428/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

robustness of regression testcases needs to be enhanced
3 participants