Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative levels to encode multiSend in Safe -> Roles -> Safe routes #5

Open
jfschwarz opened this issue Dec 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jfschwarz
Copy link
Collaborator

Given a route Safe -member-> Roles -enabled-> Safe and an array of transactions T you can encode it as either:

  • execThroughRole(multiSend(T)) ⁠ or
  • multiSend(for t in T: execThroughRole(t)) ⁠

So far we're generally encoding the former option, but there might be advantages to the latter alternative: It does not require unwrapping on the Roles mod, sparing the user from configuring a multisend unwrapper

Would also make sense to benchmark this from a gas cost perspective.

@jfschwarz jfschwarz added the enhancement New feature or request label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant