Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Allowances in Graphql schema and query #314

Merged
merged 9 commits into from
Jan 27, 2025

Conversation

cristovaoth
Copy link
Contributor

In this PR:

  • Bumped GraphQL versions.
  • Allowance events are already being handled.
  • Connected the already existing entities in the schema.
  • Actually query allowances in the rolesMod gql query.

Open Questions:

  • Does this require subgraph redeployment?
  • For refills, should we calculate accrued allowance and return it, or should this be handled at the presentation layer?

@cristovaoth cristovaoth requested a review from jfschwarz January 24, 2025 16:56
Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zodiac-roles-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 9:27am
zodiac-roles-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 9:27am

Copy link

Pull Request Test Coverage Report for Build 12963829478

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.719%

Totals Coverage Status
Change from base Build 12744876484: 0.0%
Covered Lines: 665
Relevant Lines: 666

💛 - Coveralls

@cristovaoth
Copy link
Contributor Author

Can we double check that the changes in the internal package tsconfig are not breaking types for the next release of sdk cc @frontendphil

@jfschwarz
Copy link
Collaborator

Can we double check that the changes in the internal package tsconfig are not breaking types for the next release of sdk cc @frontendphil

importing the package still seems to work 👍

@jfschwarz jfschwarz merged commit 01f676e into main Jan 27, 2025
5 checks passed
@jfschwarz jfschwarz deleted the subgraph-include-allowance-in-schema branch January 27, 2025 09:29
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants