Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ResponseHeaders option does not work currently #42

Closed
AnomalRoil opened this issue Apr 16, 2024 · 1 comment
Closed

The ResponseHeaders option does not work currently #42

AnomalRoil opened this issue Apr 16, 2024 · 1 comment

Comments

@AnomalRoil
Copy link

Currently this does not print Response Headers in the logs:

	logger := httplog.NewLogger("http-relay", httplog.Options{
		JSON:     false,
		LogLevel: slog.LevelDebug,
		Concise: false,
		ResponseHeaders: true,
	})
	r.Use(httplog.RequestLogger(logger))

This is fixed by either #34 or #39 : the problem is that the Options are not being passed to the RequestLoggerEntry in the function NewLogEntry.

@pkieltyka
Copy link
Member

thank you for noting, reviewed + merged #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants