diff --git a/src/main/java/cd/go/contrib/secrets/kubernetes/models/SecretConfig.java b/src/main/java/cd/go/contrib/secrets/kubernetes/models/SecretConfig.java index 1af5860..707d7fa 100644 --- a/src/main/java/cd/go/contrib/secrets/kubernetes/models/SecretConfig.java +++ b/src/main/java/cd/go/contrib/secrets/kubernetes/models/SecretConfig.java @@ -61,7 +61,7 @@ public String getSecurityToken() { } public String getClusterCACertData() { - return clusterCACertData; + return clusterCACertData != null && clusterCACertData.isBlank() ? null : clusterCACertData; } public String getNamespace() { diff --git a/src/test/java/cd/go/contrib/secrets/kubernetes/models/SecretConfigTest.java b/src/test/java/cd/go/contrib/secrets/kubernetes/models/SecretConfigTest.java new file mode 100644 index 0000000..a6114b6 --- /dev/null +++ b/src/test/java/cd/go/contrib/secrets/kubernetes/models/SecretConfigTest.java @@ -0,0 +1,22 @@ +package cd.go.contrib.secrets.kubernetes.models; + +import cd.go.plugin.base.GsonTransformer; +import org.junit.jupiter.api.Test; + +import java.util.HashMap; +import java.util.Map; + +import static org.assertj.core.api.Assertions.assertThat; + +class SecretConfigTest { + + @Test + public void shouldConsiderBlankCertAsNull() { + final Map settings = new HashMap<>(); + settings.put("kubernetes_cluster_ca_cert", " "); + + SecretConfig config = GsonTransformer.fromJson(GsonTransformer.toJson(settings), SecretConfig.class); + + assertThat(config.getClusterCACertData()).isNull(); + } +} \ No newline at end of file