Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s2loop_measures_test GetSignedArea.ErrorAccumulation fails on macOS #395

Open
jmr opened this issue Nov 30, 2024 · 1 comment
Open

s2loop_measures_test GetSignedArea.ErrorAccumulation fails on macOS #395

jmr opened this issue Nov 30, 2024 · 1 comment

Comments

@jmr
Copy link
Member

jmr commented Nov 30, 2024

Unclear if this is a problem with the allowed error threshold or the code.

[ RUN      ] GetSignedArea.ErrorAccumulation
.../s2geometry/src/s2/s2loop_measures_test.cc:286: Failure
The difference between expected_area and actual_area is 3.5813685350660762e-11, which exceeds allowed_error, where
expected_area evaluates to 0.78539816339744795,
actual_area evaluates to 0.78539816336163426, and
allowed_error evaluates to 3.4879033766936103e-11.

[  FAILED  ] GetSignedArea.ErrorAccumulation (343 ms)

% c++ --version
Apple clang version 15.0.0 (clang-1500.1.0.2.5)
Target: arm64-apple-darwin22.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
jmr added a commit to jmr/s2geometry that referenced this issue Nov 30, 2024
@jmr
s2loop_measures_test: Disable GetSignedArea on arm64 macOS
f4fbde3 
This fails and needs more investigation.

google#395

Disable it so we can have clean presubmit checks.
@jmr jmr mentioned this issue Nov 30, 2024
Merged
jmr added a commit that referenced this issue Nov 30, 2024
@jmr
s2loop_measures_test: Disable GetSignedArea on arm64 macOS (#396)
f5ebc3d 
This fails and needs more investigation.

#395

Disable it so we can have clean presubmit checks.
@spendres spendres mentioned this issue Dec 5, 2024
Merged
@jmr jmr changed the title s2loop_measures_test GetSignedArea.ErrorAccumulation fails on arm64 macOS s2loop_measures_test GetSignedArea.ErrorAccumulation fails on macOS Feb 1, 2025
@jmr
Copy link
Member Author

jmr commented Feb 1, 2025

Fails on the macos-13 runner, which is x86.

https://github.com/google/s2geometry/actions/runs/13091503445/job/36528655370#step:8:182

I will add a GTEST_SKIP for that, too.

jmr added a commit to jmr/s2geometry that referenced this issue Feb 1, 2025
@jmr
Skip GetSignedArea.ErrorAccumulation test on macOS
de3a157 
This was previously skipped only for AArch64 macOS.

https://github.com/google/s2geometry/blob/master/src/s2/s2loop_measures_test.cc#L256

The test fails for x86-64 macOS as well.  

google#395 (comment)

Disable for __APPLE__.
This was referenced Feb 1, 2025
Closed
Merged
jmr added a commit that referenced this issue Feb 2, 2025
@jmr
Skip GetSignedArea.ErrorAccumulation test on macOS (#407)
7c96080 
This was previously skipped only for AArch64 macOS.

https://github.com/google/s2geometry/blob/master/src/s2/s2loop_measures_test.cc#L256

The test fails for x86-64 macOS as well.  

#395 (comment)

Disable for __APPLE__.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmr