Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make path parameters required for RPC construction #536

Closed
codyoss opened this issue Dec 23, 2024 · 1 comment
Closed

Make path parameters required for RPC construction #536

codyoss opened this issue Dec 23, 2024 · 1 comment
Assignees
@coryan
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@codyoss
Copy link
Member

codyoss commented Dec 23, 2024

It would be nice if we could also read the field_behavior annotation for but because it is considered backwards compatible to remove a required annotation this is not possible. See https://google.aip.dev/203#backwards-compatibility for more details.

Related: #460
@coryan coryan added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Dec 23, 2024
@coryan coryan self-assigned this Dec 24, 2024
@coryan coryan mentioned this issue Dec 24, 2024
Merged
@coryan coryan assigned coryan and unassigned coryan Jan 2, 2025
@coryan
Copy link
Contributor

coryan commented Jan 2, 2025

I think this is done, we may want other improvements too, but path parameters are required.

@coryan coryan closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coryan coryan

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coryan @codyoss