Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: resource tags in dataset #2090

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: resource tags in dataset #2090

wants to merge 11 commits into from

Conversation

keunsoopark
Copy link

@keunsoopark keunsoopark commented Dec 19, 2024 •
edited
Loading

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2091 🦕

@keunsoopark keunsoopark requested review from a team as code owners December 19, 2024 13:26
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Dec 19, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Dec 19, 2024
@keunsoopark keunsoopark marked this pull request as draft December 19, 2024 13:50
@keunsoopark keunsoopark marked this pull request as ready for review December 19, 2024 13:50
@keunsoopark keunsoopark marked this pull request as draft December 19, 2024 15:38
@keunsoopark keunsoopark marked this pull request as ready for review December 19, 2024 15:38
@keunsoopark keunsoopark mentioned this pull request Dec 20, 2024
Open
3 tasks
Linchin
Linchin requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@Linchin Linchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding resource tags in dataset! The PR looks great overall, I just made some minor modifications. I wonder if you could add a system test, as well as a unit test for setter with None? Please let us know if you need any help. Happy holidays!

@Linchin Linchin added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 20, 2024
@Linchin Linchin assigned Linchin and unassigned yirutang Dec 20, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 20, 2024
@keunsoopark
Copy link
Author

system test

Hi @Linchin, thanks for the review.

I added system tests in system/test_clients.py

I fixed unittests for None, and added more tests for invalid values. See test_resource_tags_setter_bad_value.

Merry Christmas and happy new year!

@Linchin Linchin added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 2, 2025
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 2, 2025
@Linchin Linchin added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 2, 2025
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 2, 2025
@Linchin Linchin mentioned this pull request Jan 3, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linchin Linchin Linchin requested changes

@leahecole leahecole Awaiting requested review from leahecole leahecole is a code owner automatically assigned from googleapis/api-bigquery

Requested changes must be addressed to merge this pull request.

Assignees

@Linchin Linchin

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attach resource tags on datasets
4 participants
@keunsoopark @Linchin @yirutang @yoshi-kokoro