Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Broken CONTRIBUTING.md step #153

Open
bamnet opened this issue Sep 18, 2024 · 2 comments
Open

[docs] Broken CONTRIBUTING.md step #153

bamnet opened this issue Sep 18, 2024 · 2 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@bamnet
Copy link
Contributor

bamnet commented Sep 18, 2024

CONTRIBUTING.md includes a step which says "If you are submitting code for the first time, please add your (or your
organization's) name and contact information to the AUTHORS file."

This repo does not contain an AUTHORS file anywhere I can find.

I think this step should either be removed or an initial AUTHORS file should be added. Skimming other repositories in the googlemaps Github group, I don't see any consistent approach. Some have AUTHORS, some have CONTRIBUTORS, others have nothing.

@bamnet bamnet added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 18, 2024
@caio1985
Copy link
Collaborator

Thanks for reporting this @bamnet we are going to adjust accordingly.

@jokerttu FYI

@illuminati1911
Copy link
Contributor

Hey @bamnet. Thanks for the issue.

You are right. There is no AUTHORS file and we are not using that approach either on some of our other projects so it's probably just a left over from a template. We will have a discussion about this with the team and get back to you once it's resolved.

@illuminati1911 illuminati1911 added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed triage me I really want to be triaged. labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

4 participants