Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve GCC Warning and Address Potential Bug in Checkpoint Functionality #279

Open
LAhmos opened this issue Jun 12, 2023 · 0 comments
Open

Comments

@LAhmos
Copy link

LAhmos commented Jun 12, 2023

https://github.com/gpgpu-sim/gpgpu-sim_distribution/blob/90ec3399763d7c8512cfe7dc193473086c38ca38/src/cuda-sim/instructions.cc#LL198C40-L198C40

@aamodt @deval281shah
We are currently working on minimizing the number of gcc warnings in gpgpusim. During our review, we encountered a specific line of code where the contents of a register are being dumped. However, the problem we encountered is that the union used in this line has the potential to hold data larger than an unsigned long long. which might lead to issues when the checkpoint is used.

To address this issue, we believe it would be beneficial to modify the code and adopt a similar approach to the print_reg function in the ptx_sim.cc file of the gpgpu-sim_distribution repository. You can find the relevant code snippet at this link:

static void print_reg(FILE *fp, std::string name, ptx_reg_t value,
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant