Don't format exceptions before logging #269
Conversation
|
@ulgens thanks a lot for creating this PR, I ran into the same problem. |
ulgens
force-pushed
the
fix_exception_logging
branch
2 times, most recently
from
d74150f to
5ea3a88
Compare
|
@lucas-sonnabend The issue with test wasn't related to code, it was on Travis side. Tests are fixed on a second test run, but now coverall fails 🤕 |
|
LGTM 🚀 Don't worry about the code coverage, nothing has changed but coveralls calculation isn't always exact leading to slighty changes on its coverage report. |
|
@syrusakbary |
ulgens
force-pushed
the
fix_exception_logging
branch
from
5ea3a88 to
56ca230
Compare
ulgens
force-pushed
the
fix_exception_logging
branch
from
56ca230 to
c93bc47
Compare
|
Would love to see this merged in, as right now we're forced to use Django middleware to bubble the actual exceptions up to Sentry, leaving us with duplicate Sentry issues (one with the big truncated string as shown in the OP, another with the actually useful information like the second one shown in the OP). We've considered hiding all exceptions that come through For anyone else encountering this in Django-land, our current workaround uses graphene-sentry to allow us to bubble exceptions up. Wrapping the default GraphQL view is pretty straightforward, but does lead to the aforementioned problem of duplicate Sentry issues if you don't block the |
|
@jkimbo 👋 |
|
Is there any way we can get this merged and release? I'm happy to help if it is needed 😃 |
Fixes #253
traceback.format_exceptionis added toreport_errorwith graphql-python/graphql-core#154 two years ago, it solves another problem but i couldn't understand why did anyone need to stringify all exceptions on such central place. It removes all details of an exception and downgrades is to simple string. That change makes crucial impact on error logging.Before the change:
All exceptions have same type and same title. No traceback. There are some autogenerated breadcrumbs thanks to Sentry, but it's impossible to find why and where this error is happening. Message is truncated. All details are lost.
After the change:
Exceptions have their own types. Message is short, clear and gives information. Traceback is on place. Breadcrumbs are useful.