Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log error but return nil to ensure deps.dev continues if package is not found #2416

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Jan 2, 2025

Description of the PR

fixes #2415

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@pxp928 pxp928 requested a review from lumjjb January 2, 2025 21:38
@pxp928
Copy link
Collaborator Author

pxp928 commented Jan 2, 2025

@lumjjb this causes an issue with the recent release.

@pxp928 pxp928 requested a review from mihaimaruseac January 2, 2025 21:39
internal/client/depsdevclient/deps_dev_client.go Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 6, 2025
@kodiakhq kodiakhq bot merged commit 1e2e2e7 into main Jan 6, 2025
9 of 10 checks passed
@kodiakhq kodiakhq bot deleted the pxp928-issue-2415 branch January 6, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] deps.dev fails when package not found
3 participants