Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR comment should take in account allowed stages #100

Open
mchv opened this issue Jan 3, 2024 · 3 comments
Open

PR comment should take in account allowed stages #100

mchv opened this issue Jan 3, 2024 · 3 comments

Comments

@mchv
Copy link
Member

mchv commented Jan 3, 2024

When the riff-raff config does not contains CODE as a staging environment it seems odd to default to it. Similarly when allowedStage contain only one stage (PROD or INFRA for instance), my expectation will be top use it rather than defaulting to CODE.

Screenshot 2024-01-03 at 16 58 37
@akash1810
Copy link
Member

Not sure how this would play with the commentingStage property 🤔.

@akash1810
Copy link
Member

Wonder what the behaviour should be if allowedStages in riff-raff.yaml is a list of 1? Should that be treated the same as a PROD stage, where we're discouraged from deploying a non-main branch to it?

That is should the logic be:

  • If allowedStages is one item, do not comment
  • If allowedStages has multiple items, remove PROD, sort alphabetically, comment using the first value

@tjsilver
Copy link

Wonder what the behaviour should be if allowedStages in riff-raff.yaml is a list of 1? Should that be treated the same as a PROD stage, where we're discouraged from deploying a non-main branch to it?

That is should the logic be:

* If `allowedStages` is one item, do not comment

* If `allowedStages` has multiple items, remove `PROD`, sort alphabetically, comment using the first value

That sounds sensible to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants