You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the riff-raff config does not contains CODE as a staging environment it seems odd to default to it. Similarly when allowedStage contain only one stage (PROD or INFRA for instance), my expectation will be top use it rather than defaulting to CODE.
The text was updated successfully, but these errors were encountered:
Wonder what the behaviour should be if allowedStages in riff-raff.yaml is a list of 1? Should that be treated the same as a PROD stage, where we're discouraged from deploying a non-main branch to it?
That is should the logic be:
If allowedStages is one item, do not comment
If allowedStages has multiple items, remove PROD, sort alphabetically, comment using the first value
Wonder what the behaviour should be if allowedStages in riff-raff.yaml is a list of 1? Should that be treated the same as a PROD stage, where we're discouraged from deploying a non-main branch to it?
That is should the logic be:
* If `allowedStages` is one item, do not comment
* If `allowedStages` has multiple items, remove `PROD`, sort alphabetically, comment using the first value
When the riff-raff config does not contains
CODE
as a staging environment it seems odd to default to it. Similarly whenallowedStage
contain only one stage (PROD
orINFRA
for instance), my expectation will be top use it rather than defaulting toCODE
.The text was updated successfully, but these errors were encountered: