Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect eslint/prettier config in project generator #2535

Open
akash1810 opened this issue Dec 10, 2024 · 0 comments
Open

Incorrect eslint/prettier config in project generator #2535

akash1810 opened this issue Dec 10, 2024 · 0 comments

Comments

@akash1810
Copy link
Member

The project generator does not configure eslint to fail on Prettier errors. This means inconsistent quote marks, spacing, etc are never caught. Specifically, the package.json is missing the eslint-plugin-prettier dependency.

We should either:

  • Fail the lint step on Prettier errors
  • OR remove Prettier entirely

See https://github.com/guardian/apps-anomaly-detection/pull/10 for a worked example of the former.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant