Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look at rollup typescript plugin we're using #1208

Closed
5 tasks
Tracked by #1343
jamesmockett opened this issue Feb 15, 2024 · 1 comment
Closed
5 tasks
Tracked by #1343

Look at rollup typescript plugin we're using #1208

jamesmockett opened this issue Feb 15, 2024 · 1 comment
Assignees
Labels
Bug Something isn't working 📦 npm Affects a @guardian package on NPM

Comments

@jamesmockett
Copy link
Contributor

jamesmockett commented Feb 15, 2024

We ran into an issue releasing a Source update where more than one file in the build output had the same filename and hash.

We tracked the issue down to files that import InputSize.ts. The emitted filename in the build is InputSize-779f1b2b.js. Unexpectedly, files that import this type also have the same hash appended to the filename.

As we have more than one file called types.ts importing InputSize.ts the build included multiple instances of types-779f1b2b.js in the built output, overwriting each other.

To avoid this collision we've renamed of the files, although it still has the same hash: userFeedbackTypes-779f1b2b.js.

Tasks

Preview Give feedback
@jamesmockett jamesmockett changed the title Investigate how filenames are hashed by the build process Investigate how filenames are hashed by build process Feb 15, 2024
@jamesmockett jamesmockett added Bug Something isn't working 📦 npm Affects a @guardian package on NPM labels Feb 15, 2024
@sndrs sndrs changed the title Investigate how filenames are hashed by build process Look at rollup typescript plugin we're using Feb 27, 2024
@sndrs
Copy link
Member

sndrs commented May 7, 2024

superseded by #1418

@sndrs sndrs closed this as not planned Won't fix, can't repro, duplicate, stale May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working 📦 npm Affects a @guardian package on NPM
Projects
None yet
Development

No branches or pull requests

3 participants