Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation fails on latest nightly #53

Open
netthier opened this issue May 12, 2021 · 7 comments
Open

Compilation fails on latest nightly #53

netthier opened this issue May 12, 2021 · 7 comments

Comments

@netthier
Copy link

netthier commented May 12, 2021

error[E0425]: cannot find function `utf8_char_width` in module `core_str`
    --> /home/lmt/.cargo/registry/src/github.com-1ecc6299db9ec823/efi-0.2.1/src/io/mod.rs:1960:31
     |
1960 |         let width = core_str::utf8_char_width(first_byte);
     |                               ^^^^^^^^^^^^^^^ not found in `core_str`

% rustc --version
rustc 1.54.0-nightly (5c0292654 2021-05-11)
@netthier
Copy link
Author

This issue doesn't occur when building from git master, maybe bump crate version?

@gurry
Copy link
Owner

gurry commented Jun 8, 2021

@netthier Apologies for the late reply. I've been really busy with some other stuff.

I know that the compilation situation is a bit broken. Will try to find time to fix it, but can't promise anything unfortunately :(. In the meanwhile if you can raise a PR I'll be happy to accept it :)

@netthier
Copy link
Author

netthier commented Jun 8, 2021

Ah, no problem.
This should be fixable by just releasing a new crate version, since master actually runs fine, while the latest version available on crates.io doesn't.

@gurry
Copy link
Owner

gurry commented Jun 9, 2021

Okay. I'll take a look. Thanks :)

@gurry
Copy link
Owner

gurry commented Jun 9, 2021

I just checked (it's been a while since I worked with this code) and the master builds fine, but the sample application in examples fails to build. I'll have to fix that. If you have time, please feel free to do so because like I said I may not have time :(. I'll update the crate version once this issue is fixed (whether it is me or someone else who fixes it)

@netthier
Copy link
Author

netthier commented Jun 9, 2021

Seems to build fine for me by adding -Z build-std-features=compiler-builtins-mem
Full command:

cargo build --example sample_efi_app -Z build-std=core,alloc -Z build-std-features=compiler-builtins-mem --target x86_64-unknown-uefi

@gurry
Copy link
Owner

gurry commented Jun 10, 2021

I see. Thanks for noticing that.

I'll probably find some time soon and look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants