Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo improvements #1

Open
6 tasks
gaieges opened this issue Feb 28, 2019 · 5 comments
Open
6 tasks

Repo improvements #1

gaieges opened this issue Feb 28, 2019 · 5 comments

Comments

@gaieges
Copy link
Contributor

gaieges commented Feb 28, 2019

Jotting down some things here that we should come back to for OSS repo posterity

  • Improved comments that meet our standards in manifest / models content
  • Smaller base docker image (can probably use alpine now that we dont need the web3 stuff)
  • Travis CI autotest and pypi deploy on merge / tag
  • "How to use" documentation for outsiders
  • Tweaks to readme: (no more venv, now pipenv)
  • Rename python module (basemodels -> hmt-basemodels or something along those lines) and break out per component (Manifest, RequestConfig, etc)
@Villux
Copy link
Contributor

Villux commented May 29, 2019

Should travis handle pypi deploy? Latest version 0.0.6 was not in pypi.

@Villux
Copy link
Contributor

Villux commented May 29, 2019

Most likely the reason was missing tag 0.0.6

@gaieges
Copy link
Contributor Author

gaieges commented May 29, 2019

@pared-imi
Copy link
Contributor

It seems like currently there is no build that would automatically deploy to pypi.
The latest build on Travis is from a year ago.
@Villux

  1. Is there any reason to not deploy on a tag event?
  2. Are we interested in reactivating this?
  3. If so, should we do it with GitHub actions? When discussing with @e271828- I understood that at some point we wanted to migrate to GitHub Actions.

If we are interested in this I could tackle it, but I would need security credentials set in the repo settings, to which I do not have access.

@Villux
Copy link
Contributor

Villux commented Feb 27, 2023

hmm no idea anymore on this package. I think we can follow the best practices that eng team has created. I work for ML so I don't know them exactly. Let me know if you need more help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants