Fixing SearchParameter validation #6616
Conversation
|
This Pull Request has failed the formatting check Please run You can automate this auto-formatting process to execute on the git pre-push hook, by installing pre-commit and then calling |
… of LogbackTestExtension to validate that it really skipped the validation logic.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6616 +/- ##
============================================
- Coverage 83.54% 83.50% -0.04%
- Complexity 27432 28568 +1136
============================================
Files 1707 1797 +90
Lines 106185 111173 +4988
Branches 13397 13968 +571
============================================
+ Hits 88710 92838 +4128
- Misses 11750 12348 +598
- Partials 5725 5987 +262 ☔ View full report in Codecov by Sentry. |
| @@ -142,6 +146,16 @@ public void validateSearchParamOnUpdate(IBaseResource theResource, RequestDetail | |||
| if (isNotSearchParameterResource(theResource)) { | |||
| return; | |||
| } | |||
|
|
|||
| // avoid a loop when loading our hard-coded core FhirContext SearchParameters | |||
| //to address https://gitlab.com/simpatico.ai/cdr/-/issues/6986 so that we can skip Search Param validation if been set in the request | |||
There was a problem hiding this comment.
i appreciate what you're doing here, but since gitlab is proprietary software, and this is opensource stuff, directing users to an issue they might not be able to even see isn't going to be as helpful as we think
added changelog for my changes to fix https://gitlab.com/simpatico.ai/cdr/-/issues/6986
| --- | ||
| type: fix | ||
| issue: 6615 | ||
| title: "added login to skip the SearchParam Validation during update and uses of LogbackTestExtension to validate that it really skipped the validation logic." |
There was a problem hiding this comment.
Capitalize "a" to start (these get published)
And i think you mean "added logging"
don't need to give details on the test; just the fix
closes #6615