Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete gr when deleting final resource on partition #6619

Merged

Conversation

TipzCM
Copy link
Collaborator

@TipzCM TipzCM commented Jan 14, 2025

closes #6618

Copy link

Formatting check succeeded!

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.50%. Comparing base (406db33) to head (6dd4b34).
Report is 165 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6619      +/-   ##
============================================
- Coverage     83.54%   83.50%   -0.04%     
- Complexity    27432    28562    +1130     
============================================
  Files          1707     1797      +90     
  Lines        106185   111147    +4962     
  Branches      13397    13962     +565     
============================================
+ Hits          88710    92815    +4105     
- Misses        11750    12348     +598     
- Partials       5725     5984     +259     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@epeartree epeartree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please have a look a the comments

@TipzCM TipzCM enabled auto-merge (squash) January 16, 2025 15:28
@TipzCM TipzCM merged commit 5ec3e16 into master Jan 17, 2025
66 of 67 checks passed
@TipzCM TipzCM deleted the 6618-deleting-mdm-resources-on-partitions-should-cleanup branch January 17, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting the last mdm resource on a partition does not clean up the last golden resource
3 participants