Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: returning correct ledger id in tokeninfo (#163) #222

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: returning correct ledger id in tokeninfo (#163) #222

wants to merge 2 commits into from

Conversation

arianejasuwienas
Copy link
Contributor

@arianejasuwienas arianejasuwienas commented Jan 28, 2025 •
edited
Loading

Description:

The Ledger ID returned in TokenInfo will now provide the correct value.

  1. In Hardhat, the Mirror Node URL will be used to determine the Ledger ID.
  2. In Foundry, we already have access to the Chain ID, so we can use it to infer the Ledger ID.

Related issue(s):

Fixes #163

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@arianejasuwienas arianejasuwienas self-assigned this Jan 30, 2025
@arianejasuwienas arianejasuwienas marked this pull request as ready for review January 30, 2025 09:19
@arianejasuwienas arianejasuwienas requested a review from a team as a code owner January 30, 2025 09:19
@arianejasuwienas arianejasuwienas added the feature Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Jan 30, 2025
@arianejasuwienas arianejasuwienas changed the title fix: guessing ledger id form the mirrornode url instead of always usi… fix: returning correct ledger id in tokeninfo (#163) Jan 30, 2025
@arianejasuwienas arianejasuwienas changed the title fix: returning correct ledger id in tokeninfo (#163) feat: returning correct ledger id in tokeninfo (#163) Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acuarica acuarica Awaiting requested review from acuarica

At least 1 approving review is required to merge this pull request.

Assignees

@arianejasuwienas arianejasuwienas

Labels
feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
Development
Status: For Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix ledgerId when forking from Local Node
1 participant
@arianejasuwienas