Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why SpongyCastle (instead of Bouncy)? #4

Closed
Sajjon opened this issue Oct 10, 2018 · 2 comments
Closed

Question: Why SpongyCastle (instead of Bouncy)? #4

Sajjon opened this issue Oct 10, 2018 · 2 comments

Comments

@Sajjon
Copy link

Sajjon commented Oct 10, 2018

I saw (in ECKeypair.java for example) that SpongyCastle is used instead of BouncyCastle

I found this Github issue by the author about Spongy being obsolete or not but most people voted for SC being wanted.

So I just thought it would be interesting to know which advantages of SpongyCastle was attractive to prefer chose it over BouncyCastle 😄

@gregscullard
Copy link
Contributor

Hi, some time ago when we started work on the cryptography side of the SDK, we looked at many libraries and were a also conscious to ensure that keys generated from the Android+iOS wallets were fully compatible with those generated by the SDK and vice-versa. The Android wallet uses SpongyCastle so to avoid any inconsistencies it felt right to use the same in the Java SDK. Having tried other libraries such as LibSodium, compatibility wasn't consistent.

Hope this clarifies.
Greg

mehcode pushed a commit that referenced this issue Apr 22, 2019
Resolve "All QueryBuilders must validate the node pre check on a response from Hedera"

Closes #4

See merge request hedera/hedera-sdk-java!86
@jbuhacoff
Copy link

Hi, in case you need a more recent version of BouncyCastle in the SpongyCastle style, I made a tool called mybc for building your own customized BC library, so you don't need to wait for the next SpongyCastle release. There's a section in the README specifically about making a drop-in replacement for SpongyCastle. I'm using it in my Android app. Currently it's building BC version 1.62 for JDK 1.5 successfully. Links: mybc on GitHub and mybc on NPM. If it helps please star the repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants