Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all Store.sizeOfState() #17435

Open
2 tasks done
Tracked by #17316
Neeharika-Sompalli opened this issue Jan 17, 2025 · 0 comments · May be fixed by #17436
Open
2 tasks done
Tracked by #17316

Replace all Store.sizeOfState() #17435

Neeharika-Sompalli opened this issue Jan 17, 2025 · 0 comments · May be fixed by #17436
Assignees
@Neeharika-Sompalli
Milestone
v0.59

Comments

@Neeharika-Sompalli
Copy link
Member

Neeharika-Sompalli commented Jan 17, 2025 •
edited
Loading

  • Replace all Store.sizeOfState() implementations by getting a ReadableEntityIdStore and returning its e.g. numAccounts() or numBytecodes() getter as appropriate.
  • Mark KVState.size() as deprecated and ensure there are no remaining non-test usages of this API.
@Neeharika-Sompalli Neeharika-Sompalli mentioned this issue Jan 17, 2025
Open
8 tasks
@Neeharika-Sompalli Neeharika-Sompalli changed the title Replace all Store.sizeOfState() implementations by getting a ReadableEntityIdStore and returning its e.g. numAccounts() or numBytecodes() getter as appropriate. Replace all Store.sizeOfState() Jan 17, 2025
@Neeharika-Sompalli Neeharika-Sompalli linked a pull request Jan 17, 2025 that will close this issue
Draft
@Neeharika-Sompalli Neeharika-Sompalli self-assigned this Jan 20, 2025
@Neeharika-Sompalli Neeharika-Sompalli added this to the v0.59 milestone Jan 21, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Services Team Jan 21, 2025
@Neeharika-Sompalli Neeharika-Sompalli moved this from 📋 Backlog to 👀 In Review in Services Team Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Neeharika-Sompalli Neeharika-Sompalli

Labels
None yet
Projects
Services Team
Status: 👀 In Review
Milestone
v0.59
Development

Successfully merging a pull request may close this issue.

chore: Replace KVState.size() with ENTITY_COUNTS usage hashgraph/hedera-services
1 participant
@Neeharika-Sompalli