Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit selection of default payer #1438

Closed
jbair06 opened this issue Jan 9, 2025 · 4 comments
Closed

Revisit selection of default payer #1438

jbair06 opened this issue Jan 9, 2025 · 4 comments
Assignees
Milestone

Comments

@jbair06
Copy link
Member

jbair06 commented Jan 9, 2025

In the previous tool, there was a default payer setting. This would allow the user to always set the default payer of a transaction. Currently, the default payer is selected based on the keys available. User feedback suggests that in cases where a user tries to create multiple transactions where the fee payer is always the same, the current default selection of fee payer can be annoying.

One suggestion was to allow the app to remember the fee payer of the last transaction created, and use that as the default fee payer for the next transaction to be created.

Another suggestion was to add the "default fee payer" setting back into the app.

@jbair06
Copy link
Member Author

jbair06 commented Jan 9, 2025

If the fee payer was blank by default, that would likely be better than the current state. This would be a bit less annoying. Users like automation, when it helps with the tasks. If unhelpful, generally users would prefer no automation.

That said, both suggestions above would be automation based on user input, and therefore have value add. More feedback and brainstorming should be done.

@SimiHunjan SimiHunjan added this to the v0.8 milestone Jan 14, 2025
@jbair06
Copy link
Member Author

jbair06 commented Jan 25, 2025

A default payer setting needs to be added to the Settings page. If a value is present, that account should be the default fee payer for creating transactions. If the value is blank, then the fee payer defaults to no value.

Perhaps a checkbox could be added next to the default fee payer that allows the default fee payer to be 'last selected' or something similar.

One thing we want to avoid is automating value entry with a value the user does not want. In some situations, a user would appreciate the fee payer being remembered from one transaction to the next. But only if they are expecting that behavior, otherwise the automation is somewhat unexpected, and often annoying.

@jbair06
Copy link
Member Author

jbair06 commented Jan 28, 2025

This functionality should be moved to a per organization basis. Each organization should have its own settings. This settings would include the nickname, url, credentials, default fee payer account id, default max fee, and default network. This would allow a user to switch from one organization to another without having to remember to change network, or fee payer, etc.

The network can still be changed at any point, but the user will be able to set the default network per organization.

Pulling the 'organizations' out of the 'settings' would allow the usage of organizations to be similar to there entities. Meaning, an organization page can be created that would allow a user to 'add new' organizations, see a list of current organizations, and edit the settings of each.

Or, if it would work visually, this organization page described, can just replace the current organization panel in the settings page.

@jbair06
Copy link
Member Author

jbair06 commented Jan 29, 2025

The work for this issue will be done in #1495

@jbair06 jbair06 closed this as completed Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants