fix: better display of prompts on long inputs #12036
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yo-main
force-pushed
the
yomain/better-display-on-long-commands
branch
8 times, most recently
from
bf7928e to
1bdecd3
Compare
yo-main
force-pushed
the
yomain/better-display-on-long-commands
branch
5 times, most recently
from
dd5c914 to
4c9c1b4
Compare
This introduces the notion of anchor in the prompt. The prompt anchor represents the position of the left-side of the input. This anchor is needed so that we are able to correctly display the prompt input when its length is longer than the one of the prompt area itself
yo-main
force-pushed
the
yomain/better-display-on-long-commands
branch
from
4c9c1b4 to
b688246
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12218
The current prompt does not manage well long inputs:
I tried to refactor that a bit in order to enhance the user experience on that.
Strings are now scoped to their respective area. Ellipses are placed at the start and/or end of long strings, when needed. A user can them easily navigate through its input, whether using arrows or shortcut like
ctrl+aorctrl+e.