Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controls for printing and saving #25

Open
trajano opened this issue May 30, 2019 · 1 comment
Open

Add controls for printing and saving #25

trajano opened this issue May 30, 2019 · 1 comment

Comments

@trajano
Copy link

trajano commented May 30, 2019

Add the capability of printing pictures by adding an icon for print and saving videos and pictures by adding a button.

@henrygd
Copy link
Owner

henrygd commented Jun 1, 2019

The issue with downloading is that the download attribute only works if the image / video is served from the same domain, which is often not going to be the case. And you can already download by using the context menu, video controls, or long pressing.

For printing, the only way to do this that I'm aware of is hacky and verbose, and I'm not sure that it'll work across different browsers and devices. And like downloading, I'm not sure it's a common enough want to justify the additional weight of the icons and functionality. Users can always save the image or open it in a new tab, then print from there. My opinion is that both cases are covered well enough by default browser functionality.

But I will leave this issue open for a while and if others think it would be a good addition I will look into it further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants