Question regarding lru_cache

[baseplate-admin]

Hi,

I have a question. Why do you use lru_cache extensively in this code base?

Does caching a lookup really give that much of a performance improvement?

( dont take it as offensively, caching has a pitfall, i just want you to know that )

[hitblast]

@baseplate-admin Well I haven't really "extensively" used it. I've just implement a base amount of caching for the three main functions.

[baseplate-admin]

I dont think that's the case, cause when i used it, in certain python versions,

They treat

@lru_cache as @lru_cache(maxsize=None)

Better be explicit about that

[hitblast]

@baseplate-admin If that's the case, a simple commit should resolve the issue.

[baseplate-admin]

@baseplate-admin If that's the case, a simple commit should resolve the issue.

Yep. Please do remember this use case

[hitblast]

3e79418