Entity Damage Animation is not correctly implemented

[davidmayr]

Currently, the EntityAnimationPacket is sent out with the TAKE_DAMAGE Animation. This Animation does not exist anymore in 1.20.

The ID of TAKE_DAMAGE (1) is now simply unused (don't remove the please, since it will break the animations after, since all IDs are still the same and minestom is using enum ordinals here. Minecraft internally just uses int constants)

Instead, the HitAnimationPacket should be sent out. I would create a PR for this, but you are required to supply the yaw from which the damage came from, and I would rather let a more experienced minestom developer properly implement this.

[mworzala]

I ran into this when doing the 1.20 update but wasn't super happy with the solution I came up with so decided to leave it for people to send from their own combat handling for the moment (though didn't remove the old stuff).

Perhaps I'll take another crack at it.