Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Make display entities able to take matrix form as input for transformation #37

Open
Traquolix opened this issue Aug 2, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Traquolix
Copy link

Hi there,
Recently I've been trying to use the newly added display entities.
But I'm having quite a lot of trouble using them, mainly because of the maths involved.
I've found an editor that makes it quite easy to create very interesting display entity combinations, but all it does is the summon command, using the matrix system.

The problem with the current rotationRight and rotationLeft is that because it uses singular value decomposition, using rotation also changes the scale, for example.

It would be so great to have the ability to just enter the 4x4 matrix. I feel like it would help a ton. Here is how I imagine it, but kinda depends on the implementation, which I do not fully understand unfortunately.

DisplayEntityMeta.addTransformation(float[])
DisplayEntityMeta.addTransformation(float[][])

Warning : I'm not that good at maths. It might be VERY easy to translate the 4x4 matrix into scale, rotationRight, rotationLeft (and translation). But from my tests it does not seem to be that simple. Also, I'm not that used to open source projects, and know it's mostly a personal project you did on the side for your own work (and that you published to the public).
Just felt it would be very useful for plenty of people, and democratize the use of DisplayEntities in Minestom if it was a thing.

@mworzala mworzala added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 3, 2023
@mworzala
Copy link

mworzala commented Aug 3, 2023

I have no opposition to this, but its not a high priority for me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants