Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules are silently ignored if not valid JavaScript #1035

Open
thatsIch opened this issue May 24, 2022 · 1 comment
Open

Rules are silently ignored if not valid JavaScript #1035

thatsIch opened this issue May 24, 2022 · 1 comment
Labels
bug Functionality that does not work as intended/expected keep-unstale The issue will not be marked as stale by the stale-bot

Comments

@thatsIch
Copy link

Describe the bug
Upon writing custom rules, we often encounter that HTMLHint does not notify us about broken rules.

To Reproduce

  1. Define a custom rule like
module.exports = HTMLHint > {

};

Expected behavior
Like in #662 it is expected, that at least some warning is shown, which rule could not be loaded.

Additional context

The result is to be expected due to catching all errors regarding rule imports and ignoring them:

// ignore

@stale stale bot added the bot:stale Issue marked as stale because there was no activity label Jul 30, 2022
@coliff coliff removed the bot:stale Issue marked as stale because there was no activity label Jul 31, 2022
@thedaviddias thedaviddias added the keep-unstale The issue will not be marked as stale by the stale-bot label Aug 24, 2022
@htmlhint htmlhint deleted a comment from stale bot Sep 14, 2022
@coliff coliff added the bug Functionality that does not work as intended/expected label Sep 14, 2022
@thatsIch
Copy link
Author

I saw, that #662 was fixed with bad68d9.
I guess, that the solution could be pretty similar. I am unsure where to put the test-rules.

Maybe a new folder?

  • /test/test-rules/valid-rule.js
  • /test/test-rules/invalid-rule.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality that does not work as intended/expected keep-unstale The issue will not be marked as stale by the stale-bot
Projects
None yet
Development

No branches or pull requests

3 participants